Skip to content

Forgetting/projection. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 7, 2020
Merged

Forgetting/projection. #16

merged 4 commits into from
Aug 7, 2020

Conversation

@haz
Copy link
Collaborator

@haz haz commented Aug 6, 2020 •
edited
Loading

Closes #7

@haz haz requested a review from blyxxyz August 6, 2020 15:17
blyxxyz
blyxxyz reviewed Aug 6, 2020
View reviewed changes
blyxxyz
blyxxyz reviewed Aug 6, 2020
View reviewed changes
blyxxyz
blyxxyz requested changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a bunch of nitpicks, but this looks good overall.

blyxxyz
blyxxyz requested changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One last thing, and then we're done.

(You can build the docs locally to see how they turn out by running make html in the docs/ directory)

@haz
Copy link
Collaborator Author

haz commented Aug 7, 2020

Should we wait until #17 before merging this?

blyxxyz
blyxxyz approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this looks fine to merge now.

@haz haz merged commit b102a3c into master Aug 7, 2020
@haz haz mentioned this pull request Aug 7, 2020
Closed
@blyxxyz blyxxyz deleted the projection branch August 7, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxxyz blyxxyz blyxxyz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement forgetting/projection

2 participants

@haz @blyxxyz